r58143 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r58142‎ | r58143 | r58144 >
Date:16:30, 26 October 2009
Author:werdna
Status:deferred
Tags:
Comment:
Change LEFT OUTER JOIN to a RIGHT JOIN, in order to fix a bug where threads on one's talk page could not be marked as read.
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/NewMessagesController.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/NewMessagesController.php
——@@ -329,7 +329,7 @@
330330 __METHOD__, array(),
331331 array(
332332 'user_message_state' =>
333 - array( 'LEFT OUTER JOIN', $joinClause )
 333+ array( 'RIGHT JOIN', $joinClause )
334334 ) );
335335
336336 return Threads::loadFromResult( $res, $dbr );

Status & tagging log