r57993 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57992‎ | r57993 | r57994 >
Date:05:18, 22 October 2009
Author:aaron
Status:ok
Tags:
Comment:
removed more hard-coded english (bug 21190)
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -102,6 +102,11 @@
103103 'codereview-subtitle' => 'For $1',
104104
105105 'codereview-reply-link' => 'reply',
 106+
 107+ 'codereview-tests-succeeded' => 'succeeded tests',
 108+ 'codereview-tests-failed' => 'failed tests:',
 109+ 'codereview-tests-running' => 'Test cases are running...',
 110+ 'codereview-tests-aborted' => 'Test run aborted.',
106111
107112 'codereview-email-subj' => '[$1] [r$2]: New comment added',
108113 'codereview-email-body' => 'User "$1" posted a comment on r$3.
Index: trunk/extensions/CodeReview/ui/CodeRevisionView.php
@@ -317,8 +317,10 @@
318318 $success = $run->countSuccess;
319319 $failed = $total - $success;
320320 if( $failed ) {
321 - $html .= "<p><span class='mw-codereview-success'>$success</span> succeeded tests, " .
322 - "<span class='mw-codereview-fail'>$failed</span> failed tests:</p>";
 321+ $html .= "<p><span class='mw-codereview-success'>$success</span> ".
 322+ wfMsgHtml('codereview-tests-succeeded').", " .
 323+ "<span class='mw-codereview-fail'>$failed</span> ".
 324+ wfMsgHtml('codereview-tests-failed')."</p>";
323325
324326 $tests = $run->getResults( false );
325327 $html .= "<ul>\n";
@@ -327,13 +329,14 @@
328330 }
329331 $html .= "</ul>\n";
330332 } else {
331 - $html .= "<p><span class='mw-codereview-success'>$success</span> succeeded tests.</p>";
 333+ $html .= "<p><span class='mw-codereview-success'>$success</span> ".
 334+ wfMsgHtml('codereview-tests-succeeded')."</p>";
332335
333336 }
334337 } elseif( $run->status == "running" ) {
335 - $html .= "<p>Test cases are running...</p>";
 338+ $html .= wfMsgExt('codereview-tests-running','parse');
336339 } elseif( $run->status == "abort" ) {
337 - $html .= "<p>Test run aborted.</p>";
 340+ $html .= wfMsgExt('codereview-tests-aborted','parse');
338341 } else {
339342 // Err, this shouldn't happen?
340343 }

Status & tagging log