r57967 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57966‎ | r57967 | r57968 >
Date:05:36, 21 October 2009
Author:overlordq
Status:ok
Tags:
Comment:
Fix Special:ActiveUsers for PG, double-quotes are used to delimit identifiers not strings
Modified paths:
  • /trunk/phase3/includes/specials/SpecialActiveusers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialActiveusers.php
@@ -51,7 +51,7 @@
5252 $dbr = wfGetDB( DB_SLAVE );
5353 $conds = array( 'rc_user > 0' ); // Users - no anons
5454 $conds[] = 'ipb_deleted IS NULL'; // don't show hidden names
55 - $conds[] = 'rc_log_type IS NULL OR rc_log_type != "newusers"';
 55+ $conds[] = "rc_log_type IS NULL OR rc_log_type != 'newusers'";
5656 if( $this->requestedUser != '' ) {
5757 $conds[] = 'rc_user_text >= ' . $dbr->addQuotes( $this->requestedUser );
5858 }
@@ -156,4 +156,4 @@
157157 $wgOut->addHTML( $s );
158158 }
159159
160 -}
\ No newline at end of file
 160+}

Status & tagging log