r57923 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57922‎ | r57923 | r57924 >
Date:21:53, 19 October 2009
Author:siebrand
Status:deferred
Tags:
Comment:
Fix bug introduced in r53924 causing Special:TranslationChanges to break. ns::key was fed into messageKeyToGroup. Got rid of the unneeded colon.
Modified paths:
  • /trunk/extensions/Translate/SpecialTranslationChanges.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/SpecialTranslationChanges.php
@@ -25,7 +25,7 @@
2626 $this->setHeaders();
2727 $this->hours = min( 168, $wgRequest->getInt( 'hours', 24 ) );
2828
29 - $rows = TranslateUtils::translationChanges( $this->hours );
 29+ $rows = TranslateUtils::translationChanges( $this->hours, true );
3030 $wgOut->addHTMl( $this->settingsForm() . $this->output( $rows ) );
3131 }
3232
@@ -49,7 +49,7 @@
5050 }
5151
5252 protected static function timeLimitSelector( $selected = 24 ) {
53 - $items = array( 3, 6, 12, 24, 48, 72, 168 );
 53+ $items = array( 3, 6, 12, 24, 48, 72, 168 );
5454 $selector = new HTMLSelector( 'hours', 'hours', $selected );
5555 foreach ( $items as $item ) $selector->addOption( $item );
5656 return $selector->getHTML();
@@ -66,7 +66,7 @@
6767 list( $pieces, ) = explode( '/', $wgContLang->lcfirst( $row->rc_title ), 2 );
6868
6969 $group = 'Unknown';
70 - $mg = TranslateUtils::messageKeyToGroup( $row->rc_namespace, ':' . $pieces );
 70+ $mg = TranslateUtils::messageKeyToGroup( $row->rc_namespace, $pieces );
7171 if ( !is_null( $mg ) ) $group = $mg;
7272
7373 $lang = 'site';
@@ -96,10 +96,10 @@
9797
9898 $sorted[$class][$group][$lang][] = $row;
9999
100 - $batch->add( NS_USER, $row->rc_user_text );
101 - $batch->add( NS_USER_TALK, $row->rc_user_text );
 100+ $batch->add( NS_USER, $row->rc_user_text );
 101+ $batch->add( NS_USER_TALK, $row->rc_user_text );
102102 if ( $group !== 'core' ) {
103 - $batch->add( NS_MEDIAWIKI, $row->rc_title );
 103+ $batch->add( NS_MEDIAWIKI, $row->rc_title );
104104 }
105105 $batch->add( NS_MEDIAWIKI_TALK, $row->rc_title );
106106 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53924Bugfixesnikerabbit06:46, 29 July 2009

Status & tagging log