r57921 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57920‎ | r57921 | r57922 >
Date:21:41, 19 October 2009
Author:adam
Status:deferred
Tags:
Comment:
Addressing Roan's feedback on r57918
Modified paths:
  • /trunk/extensions/UsabilityInitiative/CollapsibleTabs/CollapsibleTabs.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.collapsibleTabs.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/CollapsibleTabs/CollapsibleTabs.php
@@ -18,7 +18,7 @@
1919
2020 /* Configuration */
2121 // Bump the version number every time you change any of the .css/.js files
22 -$wgCollapsibleTabsStyleVersion = 4;
 22+$wgCollapsibleTabsStyleVersion = 5;
2323
2424 /* Setup */
2525
@@ -27,7 +27,7 @@
2828 'path' => __FILE__,
2929 'name' => 'CollapsibleTabs',
3030 'author' => 'Adam Miller',
31 - 'version' => '0.0.4',
 31+ 'version' => '0.0.5',
3232 'url' => 'http://www.mediawiki.org/wiki/Extension:CollapsibleTabs',
3333 'descriptionmsg' => 'collapsibletabs-desc',
3434 );
Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -60,7 +60,7 @@
6161 array( 'src' => 'js/plugins/jquery.async.js', 'version' => 3 ),
6262 array( 'src' => 'js/plugins/jquery.autoEllipse.js', 'version' => 3 ),
6363 array( 'src' => 'js/plugins/jquery.browser.js', 'version' => 3 ),
64 - array( 'src' => 'js/plugins/jquery.collapsibleTabs.js', 'version' => 4 ),
 64+ array( 'src' => 'js/plugins/jquery.collapsibleTabs.js', 'version' => 5 ),
6565 array( 'src' => 'js/plugins/jquery.cookie.js', 'version' => 3 ),
6666 array( 'src' => 'js/plugins/jquery.delayedBind.js', 'version' => 1 ),
6767 array( 'src' => 'js/plugins/jquery.namespaceSelect.js', 'version' => 1 ),
@@ -72,10 +72,10 @@
7373 array( 'src' => 'js/plugins/jquery.wikiEditor.toc.js', 'version' => 21 ),
7474 ),
7575 'combined' => array(
76 - array( 'src' => 'js/plugins.combined.js', 'version' => 46 ),
 76+ array( 'src' => 'js/plugins.combined.js', 'version' => 47 ),
7777 ),
7878 'minified' => array(
79 - array( 'src' => 'js/plugins.combined.min.js', 'version' => 46 ),
 79+ array( 'src' => 'js/plugins.combined.min.js', 'version' => 47 ),
8080 ),
8181 ),
8282 );
Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.collapsibleTabs.js
@@ -40,11 +40,11 @@
4141 collapsible: 'li.collapsible',
4242 shifting: false,
4343 expandCondition: function(eleWidth) {
44 - return ( $('#left-navigation').position().left + $('#left-navigation').width() - 4)
 44+ return ( $('#left-navigation').position().left + $('#left-navigation').width())
4545 < ($('#right-navigation').position().left - eleWidth);
4646 },
4747 collapseCondition: function() {
48 - return ( $('#left-navigation').position().left + $('#left-navigation').width() + 4)
 48+ return ( $('#left-navigation').position().left + $('#left-navigation').width())
4949 > $('#right-navigation').position().left;
5050 }
5151 },

Follow-up revisions

RevisionCommit summaryAuthorDate
r57939EditToolbar: Add smartness to the link dialog so it detects URLs pointing to ...catrope00:33, 20 October 2009
r59204wmf-deployment: Merging usability changes from trunk...catrope18:53, 18 November 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57918fixing a descrepency with the buffer space on expanding a tabadam21:09, 19 October 2009

Status & tagging log