r57870 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57869‎ | r57870 | r57871 >
Date:20:06, 18 October 2009
Author:btongminh
Status:ok
Tags:
Comment:
Followup to r57868: Fix two strict standards warnings
Modified paths:
  • /trunk/phase3/includes/Licenses.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Licenses.php
@@ -86,7 +86,7 @@
8787 $position[] = $item;
8888 }
8989
90 - protected function makeHtml( &$tagset, $depth = 0 ) {
 90+ protected function makeHtml( $tagset, $depth = 0 ) {
9191 foreach ( $tagset as $key => $val )
9292 if ( is_array( $val ) ) {
9393 $this->html .= $this->outputOption(
Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -103,7 +103,7 @@
104104 /**
105105 * Special page entry point
106106 */
107 - public function execute() {
 107+ public function execute( $par ) {
108108 global $wgUser, $wgOut, $wgRequest;
109109
110110 $this->setHeaders();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57868Rewrote Special:Upload to allow easier extension. Mostly backwards compatible...btongminh19:41, 18 October 2009

Status & tagging log