r57843 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57842‎ | r57843 | r57844 >
Date:03:53, 17 October 2009
Author:aaron
Status:ok
Tags:
Comment:
Fix old bogus skin var call
Modified paths:
  • /trunk/extensions/FlaggedRevs/specialpages/RevisionReview_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/specialpages/RevisionReview_body.php
@@ -24,8 +24,10 @@
2525 var $unapprovedTags = 0;
2626
2727 public function __construct() {
 28+ global $wgUser;
2829 parent::__construct( 'RevisionReview', 'review' );
2930 wfLoadExtensionMessages( 'FlaggedRevs' );
 31+ $this->skin = $wgUser->getSkin();
3032 }
3133
3234 public function execute( $par ) {
@@ -285,7 +287,6 @@
286288
287289 $wgOut->addWikiText( wfMsg( 'revreview-selected', $this->page->getPrefixedText() ) );
288290
289 - $this->skin = $wgUser->getSkin();
290291 $rev = Revision::newFromTitle( $this->page, $this->oldid );
291292 # Check if rev exists
292293 # Do not mess with deleted revisions
@@ -438,10 +439,11 @@
439440 $form .= wfMsgExt( $msg, array('parse'), $this->page->getPrefixedUrl(), $this->oldid );
440441 $form .= "</div>";
441442 # Handy links to special pages
442 - $sk = $wgUser->getSkin();
443443 if( $showlinks && $wgUser->isAllowed( 'unreviewedpages' ) ) {
444 - $form .= '<p>'.wfMsg( 'returnto', $sk->makeLinkObj( SpecialPage::getTitleFor( 'UnreviewedPages' ) ) ).'</p>';
445 - $form .= '<p>'.wfMsg( 'returnto', $sk->makeLinkObj( SpecialPage::getTitleFor( 'OldReviewedPages' ) ) ).'</p>';
 444+ $form .= '<p>' . wfMsg( 'returnto',
 445+ $this->skin->makeLinkObj( SpecialPage::getTitleFor( 'UnreviewedPages' ) ) ).'</p>';
 446+ $form .= '<p>' . wfMsg( 'returnto',
 447+ $this->skin->makeLinkObj( SpecialPage::getTitleFor( 'OldReviewedPages' ) ) ).'</p>';
446448 }
447449 return $form;
448450 }
@@ -455,7 +457,7 @@
456458 }
457459 $form .= "</ul>";
458460 if( $showlinks ) {
459 - $form .= wfMsg( 'returnto', $sk->makeLinkObj( $this->page ) );
 461+ $form .= wfMsg( 'returnto', $this->skin->makeLinkObj( $this->page ) );
460462 }
461463 return $form;
462464 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r57845merged r57843aaron03:59, 17 October 2009

Status & tagging log