r57727 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57726‎ | r57727 | r57728 >
Date:21:19, 14 October 2009
Author:ialex
Status:ok
Tags:
Comment:
* (bug 21114) Special:Contributions no longer shows diff links for new revisions
* Removed some code that is newer used ($difftext is always overridden below)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -563,24 +563,13 @@
564564 $difftext = $topmarktext = '';
565565 if( $row->rev_id == $row->page_latest ) {
566566 $topmarktext .= '<span class="mw-uctop">' . $this->messages['uctop'] . '</span>';
567 - if( !$row->page_is_new ) {
568 - $difflink = $sk->linkKnown(
569 - $page,
570 - $this->messages['diff'],
571 - array(),
572 - array( 'diff' => 0 )
573 - );
574 - $difftext .= wfMsg( 'parentheses', $difflink );
575 - # Add rollback link
576 - if( $page->quickUserCan( 'rollback') && $page->quickUserCan( 'edit' ) ) {
577 - $topmarktext .= ' '.$sk->generateRollback( $rev );
578 - }
579 - } else {
580 - $difftext .= $this->messages['newarticle'];
 567+ # Add rollback link
 568+ if( !$row->page_is_new && $page->quickUserCan( 'rollback' ) && $page->quickUserCan( 'edit' ) ) {
 569+ $topmarktext .= ' '.$sk->generateRollback( $rev );
581570 }
582571 }
583572 # Is there a visible previous revision?
584 - if( !$rev->isDeleted(Revision::DELETED_TEXT) ) {
 573+ if( !$rev->isDeleted( Revision::DELETED_TEXT ) && $rev->getParentId() !== 0 ) {
585574 $difftext = $this->messages['pipe-separator'] . $sk->linkKnown(
586575 $page,
587576 $this->messages['diff'],
Index: trunk/phase3/RELEASE-NOTES
@@ -557,6 +557,7 @@
558558 false on non-special pages
559559 * (bug 21113) "Other statistics" header on Special:Statistics is no more
560560 displayed when there isn't any entry in it
 561+* (bug 21114) Special:Contributions no longer shows diff links for new revisions
561562
562563 == API changes in 1.16 ==
563564

Status & tagging log