r57723 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57722‎ | r57723 | r57724 >
Date:20:45, 14 October 2009
Author:ialex
Status:ok
Tags:
Comment:
* (bug 21113) "Other statistics" header on Special:Statistics is no more displayed when there isn't any entry in it
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialStatistics.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialStatistics.php
@@ -282,7 +282,10 @@
283283
284284 private function getOtherStats( $stats ) {
285285 global $wgLang;
286 -
 286+
 287+ if ( !count( $stats ) )
 288+ return '';
 289+
287290 $return = Xml::openElement( 'tr' ) .
288291 Xml::tags( 'th', array( 'colspan' => '2' ), wfMsgExt( 'statistics-header-hooks', array( 'parseinline' ) ) ) .
289292 Xml::closeElement( 'tr' );
Index: trunk/phase3/RELEASE-NOTES
@@ -555,6 +555,8 @@
556556 * (bug 21030) Fixed schema choices from being overwritten by defining unique field names per driver.
557557 * (bug 21115) wgCanonicalSpecialPageName javascript variable is now always
558558 false on non-special pages
 559+* (bug 21113) "Other statistics" header on Special:Statistics is no more
 560+ displayed when there isn't any entry in it
559561
560562 == API changes in 1.16 ==
561563

Status & tagging log