r57721 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57720‎ | r57721 | r57722 >
Date:20:35, 14 October 2009
Author:ialex
Status:ok
Tags:
Comment:
* (bug 21115) wgCanonicalSpecialPageName javascript variable is now always false on non-special pages

Based on a patch by Platonides - http://bug-attachment.wikimedia.org/attachment.cgi?id=6669
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -391,7 +391,8 @@
392392 'wgActionPaths' => (object)$wgActionPaths,
393393 'wgServer' => $wgServer,
394394 'wgCanonicalNamespace' => $nsname,
395 - 'wgCanonicalSpecialPageName' => SpecialPage::resolveAlias( $wgTitle->getDBkey() ),
 395+ 'wgCanonicalSpecialPageName' => $ns == NS_SPECIAL ?
 396+ SpecialPage::resolveAlias( $wgTitle->getDBkey() ) : false, # bug 21115
396397 'wgNamespaceNumber' => $wgTitle->getNamespace(),
397398 'wgPageName' => $wgTitle->getPrefixedDBKey(),
398399 'wgTitle' => $wgTitle->getText(),
Index: trunk/phase3/RELEASE-NOTES
@@ -553,6 +553,8 @@
554554 hideuser right
555555 * (bug 21026) Fixed file redirects on shared repos on non-English client wikis
556556 * (bug 21030) Fixed schema choices from being overwritten by defining unique field names per driver.
 557+* (bug 21115) wgCanonicalSpecialPageName javascript variable is now always
 558+ false on non-special pages
557559
558560 == API changes in 1.16 ==
559561

Status & tagging log