r57708 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57707‎ | r57708 | r57709 >
Date:18:19, 14 October 2009
Author:dale
Status:deferred
Tags:
Comment:
* gave nojs msg class so it can be removed once the video tag has been replaced
Modified paths:
  • /trunk/extensions/OggHandler/OggHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OggHandler/OggHandler_body.php
@@ -302,7 +302,7 @@
303303 ' ' . wfEscapeShellArg( $file->getPath() ) . ' 2>&1';
304304 $returnText = wfShellExec( $cmd, $retval );
305305 //check if it was successful or if we should try ffmpeg:
306 - if ( ! $this->removeBadFile( $dstPath, $retval ) ) {
 306+ if ( !$this->removeBadFile( $dstPath, $retval ) ) {
307307 return true;
308308 }
309309 }
@@ -642,7 +642,7 @@
643643 $showDescIcon = false;
644644
645645 //check if outputing to video tag or oggHandler
646 - if( $wgJs2VideoTagOut && $wgEnableJS2system){
 646+ if( $wgJs2VideoTagOut && $wgEnableJS2system ){
647647 //video tag output:
648648 if ( $this->isVideo ) {
649649 $playerHeight = $height;
@@ -668,12 +668,12 @@
669669 'startOffset' => $offset,
670670 'linkback' => $linkAttribs['href']
671671 );
672 -
673672 if( $wgEnableTemporalOggUrls )
674673 $videoAttr['URLTimeEncoding'] = 'true';
675674
676675 $s = Xml::tags( 'video', $videoAttr,
677676 Xml::tags('div', array(
 677+ 'class'=>'videonojs',
678678 'style'=>"overflow:hidden;".
679679 "width:{$width}px;height:{$playerHeight}px;".
680680 "border:solid thin black;padding:5px;"
@@ -687,7 +687,6 @@
688688
689689 }else{
690690 //oggHandler output:
691 -
692691 if ( $this->isVideo ) {
693692 $msgStartPlayer = wfMsg( 'ogg-play-video' );
694693 $imgAttribs = array(
@@ -917,4 +916,4 @@
918917 }
919918 }
920919
921 -?>
 920+?>
\ No newline at end of file

Status & tagging log