r57693 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57692‎ | r57693 | r57694 >
Date:00:39, 14 October 2009
Author:aaron
Status:ok
Tags:
Comment:
fixed fatal, cleaned up some nonsense
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php
@@ -54,19 +54,20 @@
5555
5656 // Return to rev page
5757 if ( !$redirTarget ) {
 58+ // Was "next & unresolved" clicked?
5859 if ( $this->jumpToNext ) {
5960 $next = $this->mRev->getNextUnresolved( $this->mPath );
6061 if ( $next ) {
61 - $redirTitle = SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() . '/' . $next );
 62+ $redirTarget = SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() . '/' . $next );
6263 } else {
63 - $redirTitle = SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() );
 64+ $redirTarget = SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() );
6465 }
6566 } else {
6667 # $redirTarget already set for comments
67 - $redirTitle = $redirTarget ? $redirTarget : $this->revLink();
 68+ $redirTarget = $this->revLink();
6869 }
6970 }
70 - $wgOut->redirect( $redirTitle->getFullUrl( array('path' => $this->mPath) ) );
 71+ $wgOut->redirect( $redirTarget->getFullUrl( array('path' => $this->mPath) ) );
7172 }
7273
7374 public function validPost( $permission ) {

Status & tagging log