r57664 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57663‎ | r57664 | r57665 >
Date:11:11, 13 October 2009
Author:werdna
Status:deferred
Tags:
Comment:
Merge r57663
Modified paths:
  • /branches/wmf-deployment/extensions/LiquidThreads (modified) (history)
  • /branches/wmf-deployment/extensions/LiquidThreads/classes/Thread.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/extensions/LiquidThreads/classes/Thread.php
@@ -555,6 +555,11 @@
556556
557557 global $wgParser, $wgOut, $wgTitle;
558558
 559+ $setTitle = false;
 560+ if ( !$wgOut->getTitle() ) {
 561+ $setTitle = true;
 562+ }
 563+
559564 // Parser gets antsy about parser options here if it hasn't parsed anything before.
560565 $wgParser->clearState();
561566 $wgParser->setTitle( $wgTitle );
@@ -574,9 +579,14 @@
575580 $fancysig = $signatureDataCache[$uid]['fancysig'];
576581
577582 // Generate signature from Parser
 583+
 584+ if ( $setTitle ) {
 585+ $user_t = Title::makeTitleSafe( NS_USER, $name );
 586+ $wgOut->setTitle( $user_t );
 587+ }
578588
579589 $sig = $wgParser->getUserSig( $user, $nickname, $fancysig );
580 - $sig = $wgOut->parseInline( $sig );
 590+ $sig = $wgOut->parse( $sig );
581591
582592 // Save into LqtView for later use.
583593 LqtView::$userSignatureCache[$name] = $sig;
Property changes on: branches/wmf-deployment/extensions/LiquidThreads
___________________________________________________________________
Name: svn:mergeinfo
584594 - /branches/REL1_15/phase3/extensions/LiquidThreads:51646
/trunk/extensions/LiquidThreads:56151-57571,57651,57653-57654
/trunk/phase3/extensions/LiquidThreads:56213,56215-56216,56218,56325,56334-56336,56338,56340,56343,56345,56347,56350,57154-57447
585595 + /branches/REL1_15/phase3/extensions/LiquidThreads:51646
/trunk/extensions/LiquidThreads:56151-57571,57651,57653-57654,57663
/trunk/phase3/extensions/LiquidThreads:56213,56215-56216,56218,56325,56334-56336,56338,56340,56343,56345,56347,56350,57154-57447

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57663Fix dumping of discussion threading data by setting a title when precaching u...werdna11:10, 13 October 2009

Status & tagging log