r57631 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57630‎ | r57631 | r57632 >
Date:21:56, 10 October 2009
Author:siebrand
Status:deferred
Tags:
Comment:
Add FIXME for two bugs
Modified paths:
  • /trunk/extensions/Translate/MessageGroups.php (modified) (history)
  • /trunk/extensions/Translate/tag/PageTranslationHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/MessageGroups.php
@@ -667,6 +667,10 @@
668668 public function getMessage( $key, $code ) {
669669 if ( $code === 'en' ) {
670670 $stuff = $this->load( 'en' );
 671+ // FIXME: throws PHP Notice: Undefined index: <key>
 672+ // when keys are added, but createMessageIndex.php is
 673+ // not run (like when a translatable page from page
 674+ // translation was added)
671675 return $stuff[$key];
672676 }
673677 $title = Title::makeTitleSafe( $this->namespaces[0], "$key/$code" );
Index: trunk/extensions/Translate/tag/PageTranslationHooks.php
@@ -227,6 +227,8 @@
228228 * like markup spanning between sections. */
229229 $page->getParse();
230230 } catch ( TPException $e ) {
 231+ // FIXME: throws "PHP Notice: Undefined variable: ret" when <translate>/</translate> is uneven
 232+ // and an 'edit conflict'.
231233 call_user_func_array( array( $status, 'fatal' ), $ret );
232234 return false;
233235 }

Status & tagging log