r57625 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r57624‎ | r57625 | r57626 >
Date:20:44, 10 October 2009
Author:midom
Status:ok (Comments)
Tags:
Comment:
um, don't die with fatal error?
Modified paths:
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogEventsList.php
——@@ -555,7 +555,7 @@
556556 if( $row->log_deleted & $field ) {
557557 global $wgUser;
558558 $permission = '';
559 - if ( $this->log_deleted & LogPage::DELETED_RESTRICTED ) {
 559+ if ( $row->log_deleted & LogPage::DELETED_RESTRICTED ) {
560560 $permission = 'suppressrevision';
561561 } elseif ( $field & LogPage::DELETED_TEXT ) {
562562 $permission = 'deletedtext';

Follow-up revisions

RevisionCommit summaryAuthorDate
r57626MFT: r57625 - avoid fatal error due to people not checking their codemidom20:46, 10 October 2009

Comments

#Comment by Mike.lifeguard (talk | contribs)   21:12, 10 October 2009

That fixed bugzilla:21080

#Comment by Tim Starling (talk | contribs)   04:45, 15 December 2009

For the record, the change which introduced this breakage was r57579.

Status & tagging log