r57614 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57613‎ | r57614 | r57615 >
Date:10:01, 10 October 2009
Author:siebrand
Status:deferred
Tags:
Comment:
Use 'ellipsis' message instead of hardcoded "..."
Modified paths:
  • /trunk/extensions/Wikidata/OmegaWiki/Editor.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/OmegaWiki/Editor.php
@@ -1057,7 +1057,7 @@
10581058 $escapedDefinition = htmlspecialchars( $definition );
10591059
10601060 if ( $this->truncate && strlen( $definition ) > $this->truncateAt )
1061 - $escapedDefinition = '<span title="' . $escapedDefinition . '">' . htmlspecialchars( mb_substr( $definition, 0, $this->truncateAt ) ) . '...</span>' . EOL;
 1061+ $escapedDefinition = '<span title="' . $escapedDefinition . '">' . htmlspecialchars( mb_substr( $definition, 0, $this->truncateAt ) ) . wfMsg( 'ellipsis' ) . '</span>' . EOL;
10621062
10631063 return $definedMeaningAsLink . ": " . $escapedDefinition;
10641064 }
@@ -1108,7 +1108,7 @@
11091109 if ( !$this->truncate || strlen( $value ) <= $this->truncateAt )
11101110 return $escapedValue;// $parserOutput->getText();
11111111 else
1112 - return '<span title="' . $escapedValue . '">' . htmlspecialchars( substr( $value, 0, $this->truncateAt ) ) . '...</span>' . EOL;
 1112+ return '<span title="' . $escapedValue . '">' . htmlspecialchars( substr( $value, 0, $this->truncateAt ) ) . wfMsg( 'ellipsis' ) . '</span>' . EOL;
11131113 }
11141114
11151115 public function getEditHTML( IdStack $idPath, $value ) {

Status & tagging log