r57610 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r57609‎ | r57610 | r57611 >
Date:09:14, 10 October 2009
Author:midom
Status:resolved (Comments)
Tags:
Comment:
adding partial job_param to job_cmd index
Modified paths:
  • /trunk/phase3/maintenance/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tables.sql
——@@ -1185,7 +1185,7 @@
11861186 job_params blob NOT NULL
11871187 ) /*$wgDBTableOptions*/;
11881188
1189 -CREATE INDEX /*i*/job_cmd ON /*_*/job (job_cmd, job_namespace, job_title);
 1189+CREATE INDEX /*i*/job_cmd ON /*_*/job (job_cmd, job_namespace, job_title, job_params(128));
11901190
11911191
11921192 -- Details of updates to cached special pages

Follow-up revisions

RevisionCommit summaryAuthorDate
r59720Update patch-job.sql for r57610 and documentation updates.tstarling03:01, 4 December 2009

Comments

#Comment by Simetrical (talk | contribs)   19:52, 9 December 2009

Doesn't this need an updater written?

#Comment by Tim Starling (talk | contribs)   04:32, 15 December 2009

Domas, can you explain what this is for so that we can have some idea of whether we need to add an updater for it?

#Comment by Midom (talk | contribs)   09:41, 15 December 2009

apparently we can have any jobs with same cmd/namespace/title, and as our code deletes them by the cmd/namespace/title/params set (I guess for dupe elimination), adding job_params to the index is a must.

Status & tagging log