r57572 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57571‎ | r57572 | r57573 >
Date:17:16, 9 October 2009
Author:werdna
Status:deferred
Tags:
Comment:
Merge r57571
Modified paths:
  • /branches/wmf-deployment/extensions/LiquidThreads (modified) (history)
  • /branches/wmf-deployment/extensions/LiquidThreads/classes/View.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/extensions/LiquidThreads/classes/View.php
@@ -770,7 +770,7 @@
771771 $commands = $this->threadCommands( $thread );
772772 $menuHTML = Xml::tags( 'ul', array( 'class' => 'lqt-thread-toolbar-command-list' ),
773773 $this->listItemsForCommands( $commands ) );
774 -
 774+
775775 $triggerText = Xml::tags( 'span', array( 'class' => 'lqt-thread-actions-icon' ),
776776 ' ' );
777777 $dropDownTrigger = Xml::tags( 'div',
@@ -1129,7 +1129,8 @@
11301130 $replies = $thread->replies();
11311131
11321132 foreach( $replies as $reply ) {
1133 - $content = $reply->root()->getContent();
 1133+ $content = '';
 1134+ if ( $reply->root() ) $content = $reply->root()->getContent();
11341135
11351136 if ( trim($content) != '' ) {
11361137 return true;
@@ -1138,6 +1139,10 @@
11391140 if ( self::threadContainsRepliesWithContent( $reply ) ) {
11401141 return true;
11411142 }
 1143+
 1144+ if ( $reply->type() == Threads::TYPE_MOVED ) {
 1145+ return true;
 1146+ }
11421147 }
11431148
11441149 return false;
@@ -1227,8 +1232,10 @@
12281233 $options['mustShowThreads'] = $mustShowThreads;
12291234
12301235 // Don't show blank posts unless we have to
1231 - $content = $thread->root()->getContent();
 1236+ $content = '';
 1237+ if ( $thread->root() ) $content = $thread->root()->getContent();
12321238 if ( trim($content) == '' &&
 1239+ $thread->type() != Threads::TYPE_MOVED &&
12331240 ! self::threadContainsRepliesWithContent( $thread ) &&
12341241 ! array_key_exists( $thread->id(), $mustShowThreads ) ) {
12351242
Property changes on: branches/wmf-deployment/extensions/LiquidThreads
___________________________________________________________________
Modified: svn:mergeinfo
12361243 Merged /trunk/extensions/LiquidThreads:r57567-57571

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57571Fix bugs for threads with no associated root page (for various reasons).werdna17:16, 9 October 2009

Status & tagging log