r57487 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57486‎ | r57487 | r57488 >
Date:21:21, 7 October 2009
Author:raymond
Status:ok
Tags:
Comment:
Replace hardcoded "pages" with the appropriate message and i18n the number and pipe separator.
One point to check: I am not sure why the number of pages only was wrapped in a span.
Now the number and the text are wrapped.
Modified paths:
  • /trunk/extensions/Collection/Collection.templates.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.templates.php
@@ -450,7 +450,7 @@
451451 <td style="width: 45%; vertical-align: top;">
452452 <div style="padding: 10px; border: 1px solid #aaa; background-color: #f9f9f9;">
453453 <strong style="font-size: 1.2em;"><?php $this->msg('coll-suggest_your_book') ?></strong>
454 - (<span id="coll-num_pages"><?php echo htmlspecialchars($this->data['num_pages']) ?></span> pages | <a href="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrl('Book')) ?>" title="<?php $this->msg('coll-show_collection_tooltip') ?>"><?php $this->msg('coll-suggest_show') ?></a>)
 454+ (<span id="coll-num_pages"><?php echo wfMsgExt( 'coll-n_pages', 'parsemag', $GLOBALS['wgLang']->formatNum( $this->data['num_pages'] ) )?></span><?php echo wfMsg( 'pipe-separator' )?><a href="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrl('Book')) ?>" title="<?php $this->msg('coll-show_collection_tooltip') ?>"><?php $this->msg('coll-suggest_show') ?></a>)
455455 <ul id="collectionMembers" style="list-style: none; margin-left: 0;">
456456 <?php echo $this->getMemberList(); ?>
457457 </ul>

Status & tagging log