r57473 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57472‎ | r57473 | r57474 >
Date:18:20, 7 October 2009
Author:brion
Status:ok
Tags:
Comment:
merge r57472 from trunk -- check $this->mTitle before using
Modified paths:
  • /branches/wmf-deployment/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/includes/OutputPage.php
@@ -1819,7 +1819,7 @@
18201820 //add user js if enabled:
18211821 if( $this->isUserJsAllowed() && $wgUser->isLoggedIn() ) {
18221822 $action = $wgRequest->getVal( 'action', 'view' );
1823 - if( $this->mTitle->isJsSubpage() and $sk->userCanPreview( $action ) ) {
 1823+ if( $this->mTitle && $this->mTitle->isJsSubpage() and $sk->userCanPreview( $action ) ) {
18241824 # XXX: additional security check/prompt?
18251825 $this->addInlineScript( $wgRequest->getText( 'wpTextbox1' ) );
18261826 } else {
Property changes on: branches/wmf-deployment/includes/OutputPage.php
___________________________________________________________________
Name: svn:mergeinfo
18271827 + /branches/REL1_15/phase3/includes/OutputPage.php:51646
/branches/wmf-deployment/includes/OutputPage.php:53381
/trunk/phase3/includes/OutputPage.php:56213,56215-56216,56218,56334-56336,56338,56340,56343,56345,56347,56350,57154-57447,57472

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57472check that $this->mTitle isn't empty before checking if it's a user css/js pa...brion18:18, 7 October 2009

Status & tagging log