r57441 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57440‎ | r57441 | r57442 >
Date:22:14, 6 October 2009
Author:brion
Status:ok
Tags:
Comment:
Cleanup r57359 -- removing PHP4-isms (references not needed to pass objects unless you're going to replace them with different objects as outparams)
Modified paths:
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -565,7 +565,7 @@
566566 $watched: Whether or not the change is watched by the user.
567567
568568 'ConfirmEmailComplete': Called after a user's email has been confirmed successfully
569 -&$user: user (object) whose email is being confirmed
 569+$user: user (object) whose email is being confirmed
570570
571571 'ContribsPager::getQueryInfo': Before the contributions query is about to run
572572 &$pager: Pager object for contributions
@@ -848,7 +848,7 @@
849849 &$this->mStripState: Parser's internal StripState object
850850
851851 'InvalidateEmailComplete': Called after a user's email has been invalidated successfully
852 -&$user: user (object) whose email is being invalidated
 852+$user: user (object) whose email is being invalidated
853853
854854 'IsFileCacheable': Override the result of Article::isFileCacheable() (if true)
855855 $article: article (object) being checked
Index: trunk/phase3/includes/User.php
@@ -2946,7 +2946,7 @@
29472947 */
29482948 function confirmEmail() {
29492949 $this->setEmailAuthenticationTimestamp( wfTimestampNow() );
2950 - wfRunHooks( 'ConfirmEmailComplete', array( &$this ) );
 2950+ wfRunHooks( 'ConfirmEmailComplete', array( $this ) );
29512951 return true;
29522952 }
29532953
@@ -2961,7 +2961,7 @@
29622962 $this->mEmailToken = null;
29632963 $this->mEmailTokenExpires = null;
29642964 $this->setEmailAuthenticationTimestamp( null );
2965 - wfRunHooks( 'InvalidateEmailComplete', array( &$this ) );
 2965+ wfRunHooks( 'InvalidateEmailComplete', array( $this ) );
29662966 return true;
29672967 }
29682968

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57359redoing r38040: two new hooks for email confirmation/invalidation, both are i...ashley16:26, 4 October 2009

Status & tagging log