r57381 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57380‎ | r57381 | r57382 >
Date:13:46, 5 October 2009
Author:werdna
Status:deferred
Tags:
Comment:
Remove unnecessary explicit "thread.", which breaks when we have a table prefix. Resolves bug 20951
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/Threads.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/Threads.php
@@ -117,7 +117,7 @@
118118 if ( array_key_exists( $post->getID(), self::$cache_by_root ) ) {
119119 return self::$cache_by_root[$post->getID()];
120120 }
121 - $ts = Threads::where( array( 'thread.thread_root' => $post->getID() ) );
 121+ $ts = Threads::where( array( 'thread_root' => $post->getID() ) );
122122 return self::assertSingularity( $ts, 'thread_root', $post->getID() );
123123 }
124124
@@ -131,7 +131,7 @@
132132 }
133133
134134 static function withSummary( $article ) {
135 - $ts = Threads::where( array( 'thread.thread_summary_page' => $article->getId() ) );
 135+ $ts = Threads::where( array( 'thread_summary_page' => $article->getId() ) );
136136 return self::assertSingularity( $ts, 'thread_summary_page', $article->getId() );
137137 }
138138

Follow-up revisions

RevisionCommit summaryAuthorDate
r57383Fix LiquidThreads API documentation (bug 20951)...werdna13:53, 5 October 2009

Status & tagging log