r57358 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57357‎ | r57358 | r57359 >
Date:16:16, 4 October 2009
Author:ashley
Status:deferred
Tags:
Comment:
MultiUpload: actually show the image(s); code from wikia codebase
Modified paths:
  • /trunk/extensions/MultiUpload/SpecialMultipleUpload.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MultiUpload/SpecialMultipleUpload.body.php
@@ -168,13 +168,13 @@
169169 $this->mainUploadForm( wfMsg( 'multiupload-no-files' ) );
170170 } else {
171171 $this->mShowUploadForm = false;
172 - $wgOut->redirect(''); // clear the redirect, we want to show a nice page of images
 172+ $wgOut->redirect( '' ); // clear the redirect, we want to show a nice page of images
173173 $this->mShowUploadForm = true;
174174 if( $this->mHasWarning ) {
175175 $this->showWarningOptions();
176176 }
177177 }
178 - $wgOut->addHTML( Xml::closeElement( 'form' ) . "\n");
 178+ $wgOut->addHTML( Xml::closeElement( 'form' ) . "\n" );
179179 }
180180
181181 /**
@@ -182,10 +182,10 @@
183183 * @access private
184184 */
185185 function showSuccess() {
186 - global $wgUser, $wgOut, $wgContLang;
 186+ global $wgUser, $wgOut;
187187 $t = $this->mLocalFile->getTitle();
188188 $wgOut->addHTML( '<h2>' . wfMsg( 'multiupload-fileuploaded' ) . '</h2>' );
189 - $wgOut->addWikiText( "[[:{$t->getFullText()}]]" );
 189+ $wgOut->addHTML( $wgUser->getSkin()->makeThumbLink2( $t, $this->mLocalFile, array( 'caption' => $t->getText() ) ) );
190190 }
191191
192192 /**
@@ -285,7 +285,7 @@
286286 ? 'checked="checked"'
287287 : '';
288288
289 - $wgOut->addScriptFile( $wgScriptPath.'/extensions/MultiUpload/multiupload.js' );
 289+ $wgOut->addScriptFile( $wgScriptPath . '/extensions/MultiUpload/multiupload.js' );
290290 $wgOut->addHTML( "
291291 <form id='upload' method='post' enctype='multipart/form-data' action=\"$action\">
292292 <table border='0' width='90%'>

Status & tagging log