r57257 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57256‎ | r57257 | r57258 >
Date:21:56, 1 October 2009
Author:nimishg
Status:ok
Tags:
Comment:
debug messages removed (!)
Modified paths:
  • /trunk/extensions/UsabilityInitiative/ClickTracking/ApiSpecialClickTracking.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/ClickTracking/SpecialClickTracking.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/ClickTracking/SpecialClickTracking.js
@@ -29,8 +29,8 @@
3030 //change name
3131 $("#user_def_alter_legend").text($("#user_def_alter_legend").data("defaultChangeText") + " " + defName);
3232 $("#user_def_alter_legend").data("currentlyEditing", defName);
33 - console.dir(userDef);
3433
 34+
3535 var setContribs = function(conditionArray, contribName){
3636
3737 initialDiv = $("<div>").attr("id", contribName +"_div");
@@ -51,7 +51,6 @@
5252 initialDiv.append(textDiv);
5353
5454 var i=0;
55 - console.dir(conditionArray);
5655 for( var condition in conditionArray){
5756 i++;
5857 conditionDiv = $("<div>").attr("id", contribName + "_range_" + i + "_div");
Index: trunk/extensions/UsabilityInitiative/ClickTracking/ApiSpecialClickTracking.php
@@ -15,8 +15,6 @@
1616 */
1717 public function execute(){
1818
19 - $file = fopen("/Users/nimishgautam/logs/PHPLOG.txt", "a");
20 -
2119
2220 $params = $this->extractRequestParams();
2321 $this->validateParams( $params );
@@ -26,10 +24,6 @@
2725 $increment = $params['increment'];
2826 $userDefString = $params['userdefs'];
2927
30 - fwrite($file, var_export($_REQUEST, true) . "\n\n");
31 - fwrite($file, var_export($params, true). "\n\n");
32 - fclose($file);
33 -
3428 $click_data = array();
3529 try{
3630 $click_data = SpecialClickTracking::getChartData($event_id, $startdate, $enddate, $increment, $userDefString);

Status & tagging log