r57249 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57248‎ | r57249 | r57250 >
Date:20:54, 1 October 2009
Author:dale
Status:deferred
Tags:
Comment:
* fixed output size display for encode video
Modified paths:
  • /trunk/phase3/js2/mwEmbed/libAddMedia/mvFirefogg.js (modified) (history)

Diff [purge]

Index: trunk/phase3/js2/mwEmbed/libAddMedia/mvFirefogg.js
@@ -645,7 +645,7 @@
646646 var encodingStatus = function() {
647647 var status = _this.fogg.status();
648648
649 - if( _this.show_preview == true ){
 649+ if( _this.show_preview == true && _this.fogg.state == 'encoding'){
650650 _this.doRenderPreview();
651651 }
652652
@@ -709,26 +709,18 @@
710710 'height': vH
711711 });
712712 //if large video resize the dialog box:
713 - if( vW > 400){
 713+ if( vW + 5 > 400){
714714 //also resize the dialog box
715 - $j('#upProgressDialog').parent().animate({
716 - 'width': vW + 5,
717 - 'height' : vH + 30
718 - });
 715+ $j('#upProgressDialog').dialog('option', 'width', vW + 20);
 716+ $j('#upProgressDialog').dialog('option', 'height', vH + 120);
719717
720 - //also position the parent container
721 - $j('#upProgressDialog').parent().animate({
722 - 'left': ($j(document).width() - (vW + 5) )/2 ,
723 - 'top': ($j(document).height() - (vH + 30) )/2
724 - });
 718+ //also position the dialog container
 719+ $j('#upProgressDialog').dialog('option', 'position', 'center');
725720 }
726 - }
727 -
728 - //set flag to diplay video at res
 721+ }
729722 v.removeEventListener("loadedmetadata", resizeVid, true);
730723 v.addEventListener("loadedmetadata", resizeVid, true);
731 - v.load();
732 -
 724+ v.load();
733725 }, 1000);
734726 }
735727 },
@@ -835,6 +827,7 @@
836828 this.action_done = true;
837829 this.fogg.cancel();
838830 $j(dlElm).empty().dialog('close');
 831+ return false;
839832 }
840833 } else{
841834 return false;

Status & tagging log