r57223 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57222‎ | r57223 | r57224 >
Date:14:45, 1 October 2009
Author:ialex
Status:deferred
Tags:
Comment:
* (bug 20908) reassignEdits.php was calling userSpecification() which was moved to the ReassignEdits class with the maintenance scripts rewrite
* Also fix some E_STRICT errors
Modified paths:
  • /trunk/phase3/maintenance/reassignEdits.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/reassignEdits.php
@@ -38,8 +38,8 @@
3939 public function execute() {
4040 if( $this->hasArg(0) && $this->hasArg(1) ) {
4141 # Set up the users involved
42 - $from =& $this->initialiseUser( $this->getArg(0) );
43 - $to =& $this->initialiseUser( $this->getArg(1) );
 42+ $from = $this->initialiseUser( $this->getArg(0) );
 43+ $to = $this->initialiseUser( $this->getArg(1) );
4444
4545 # If the target doesn't exist, and --force is not set, stop here
4646 if( $to->getId() || $this->hasOption('force') ) {
@@ -100,9 +100,9 @@
101101 if( $total ) {
102102 # Reassign edits
103103 $this->output( "\nReassigning current edits..." );
104 - $res = $dbw->update( 'revision', userSpecification( $to, 'rev_user', 'rev_user_text' ), $this->userConditions( $from, 'rev_user', 'rev_user_text' ), __METHOD__ );
 104+ $res = $dbw->update( 'revision', $this->userSpecification( $to, 'rev_user', 'rev_user_text' ), $this->userConditions( $from, 'rev_user', 'rev_user_text' ), __METHOD__ );
105105 $this->output( "done.\nReassigning deleted edits..." );
106 - $res = $dbw->update( 'archive', userSpecification( $to, 'ar_user', 'ar_user_text' ), $this->userConditions( $from, 'ar_user', 'ar_user_text' ), __METHOD__ );
 106+ $res = $dbw->update( 'archive', $this->userSpecification( $to, 'ar_user', 'ar_user_text' ), $this->userConditions( $from, 'ar_user', 'ar_user_text' ), __METHOD__ );
107107 $this->output( "done.\n" );
108108 # Update recent changes if required
109109 if( $rc ) {

Status & tagging log