r57216 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57215‎ | r57216 | r57217 >
Date:13:01, 1 October 2009
Author:werdna
Status:deferred
Tags:
Comment:
Deploy r57215, fixes fatals
Modified paths:
  • /branches/wmf-deployment/extensions/LiquidThreads (modified) (history)
  • /branches/wmf-deployment/extensions/LiquidThreads/classes/View.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/extensions/LiquidThreads/classes/View.php
@@ -561,10 +561,12 @@
562562 'enabled' => true, 'icon' => 'reply.png', 'showlabel' => 1,
563563 'tooltip' => wfMsg( 'lqt_reply' ) );
564564
565 - $commands['link'] = array( 'label' => wfMsgExt( 'lqt_permalink', 'parseinline' ),
566 - 'href' => $thread->title()->getFullURL(),
567 - 'enabled' => true, 'icon' => 'link.png',
568 - 'tooltip' => wfMsgExt( 'lqt_permalink', 'parseinline' ) );
 565+ if ($thread->title()) {
 566+ $commands['link'] = array( 'label' => wfMsgExt( 'lqt_permalink', 'parseinline' ),
 567+ 'href' => $thread->title()->getFullURL(),
 568+ 'enabled' => true, 'icon' => 'link.png',
 569+ 'tooltip' => wfMsgExt( 'lqt_permalink', 'parseinline' ) );
 570+ }
569571
570572 if ( $thread->root()->getTitle()->quickUserCan( 'edit' ) ) {
571573 $commands['edit'] = array( 'label' => wfMsgExt( 'edit', 'parseinline' ),
Property changes on: branches/wmf-deployment/extensions/LiquidThreads
___________________________________________________________________
Name: svn:mergeinfo
572574 - /branches/REL1_15/phase3/extensions/LiquidThreads:51646
/trunk/extensions/LiquidThreads:56151-57116,57130-57134,57169,57193,57195,57198,57200-57206
/trunk/phase3/extensions/LiquidThreads:56213,56215-56216,56218,56325,56334-56336,56338,56340,56343,56345,56347,56350
573575 + /branches/REL1_15/phase3/extensions/LiquidThreads:51646
/trunk/extensions/LiquidThreads:56151-57116,57130-57134,57169,57193,57195,57198,57200-57206,57215
/trunk/phase3/extensions/LiquidThreads:56213,56215-56216,56218,56325,56334-56336,56338,56340,56343,56345,56347,56350

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57215Guard for threads with no title()werdna13:00, 1 October 2009

Status & tagging log