r57145 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57144‎ | r57145 | r57146 >
Date:19:38, 30 September 2009
Author:werdna
Status:ok
Tags:
Comment:
Unmerge r57129 and r57122 from wmf-deployment (LiquidThreads only), breaks because the necessary core changes have not yet been deployed.
Modified paths:
  • /branches/wmf-deployment/extensions/LiquidThreads (modified) (history)
  • /branches/wmf-deployment/extensions/LiquidThreads/pages/TalkpageView.php (modified) (history)
  • /branches/wmf-deployment/extensions/LiquidThreads/pages/ThreadPermalinkView.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/extensions/LiquidThreads/pages/ThreadPermalinkView.php
@@ -137,18 +137,6 @@
138138 $this->doInlineEditForm();
139139 return false;
140140 }
141 -
142 - // Expose feed links.
143 - global $wgFeedClasses, $wgScriptPath, $wgServer;
144 - $thread = $this->thread->topmostThread()->title()->getPrefixedText();
145 - $apiParams = array( 'action' => 'feedthreads', 'type' => 'replies|newthreads',
146 - 'thread' => $thread );
147 - $urlPrefix = wfScript('api').'?';
148 - foreach( $wgFeedClasses as $format => $class ) {
149 - $theseParams = $apiParams + array( 'feedformat' => $format );
150 - $url = $urlPrefix . wfArrayToCGI( $theseParams );
151 - $this->output->addFeedLink( $format, $url );
152 - }
153141
154142 self::addJSandCSS();
155143 $this->output->setSubtitle( $this->getSubtitle() );
Index: branches/wmf-deployment/extensions/LiquidThreads/pages/TalkpageView.php
@@ -183,17 +183,6 @@
184184 $this->output->setPageTitle( $this->title->getPrefixedText() );
185185 self::addJSandCSS();
186186
187 - // Expose feed links.
188 - global $wgFeedClasses, $wgScriptPath, $wgServer;
189 - $apiParams = array( 'action' => 'feedthreads', 'type' => 'replies|newthreads',
190 - 'talkpage' => $this->title->getPrefixedText() );
191 - $urlPrefix = wfScript('api').'?';
192 - foreach( $wgFeedClasses as $format => $class ) {
193 - $theseParams = $apiParams + array( 'feedformat' => $format );
194 - $url = $urlPrefix . wfArrayToCGI( $theseParams );
195 - $this->output->addFeedLink( $format, $url );
196 - }
197 -
198187 $sk = $this->user->getSkin();
199188
200189 $article = new Article( $this->title );
Property changes on: branches/wmf-deployment/extensions/LiquidThreads
___________________________________________________________________
Name: svn:mergeinfo
201190 - /branches/REL1_15/phase3/extensions/LiquidThreads:51646
/trunk/extensions/LiquidThreads:56151-57134
/trunk/phase3/extensions/LiquidThreads:56213,56215-56216,56218,56325,56334-56336,56338,56340,56343,56345,56347,56350
202191 + /branches/REL1_15/phase3/extensions/LiquidThreads:51646
/trunk/extensions/LiquidThreads:56151-57116,57130-57134
/trunk/phase3/extensions/LiquidThreads:56213,56215-56216,56218,56325,56334-56336,56338,56340,56343,56345,56347,56350

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57122Expose LiquidThreads feed links through the proper UI (feed links in the side...werdna17:53, 30 September 2009
r57129Replace hardcoded api.php with a call to wfScript(api) in a few places per co...werdna18:44, 30 September 2009

Status & tagging log