r57120 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57119‎ | r57120 | r57121 >
Date:17:44, 30 September 2009
Author:werdna
Status:ok (Comments)
Tags:
Comment:
Fix for r57119, remove double-/ in URLs
Modified paths:
  • /trunk/phase3/includes/specials/SpecialWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialWatchlist.php
@@ -20,7 +20,7 @@
2121 global $wgServer, $wgScriptPath, $wgFeedClasses;
2222 $apiParams = array( 'action' => 'feedwatchlist', 'allrev' => 'allrev',
2323 'wlowner' => $wgUser->getName(), 'wltoken' => $wlToken );
24 - $feedTemplate = $wgServer . '/' . $wgScriptPath . '/api.php?';
 24+ $feedTemplate = $wgServer . $wgScriptPath . '/api.php?';
2525
2626 foreach( $wgFeedClasses as $format => $class ) {
2727 $theseParams = $apiParams + array( 'feedformat' => $format );

Follow-up revisions

RevisionCommit summaryAuthorDate
r57129Replace hardcoded api.php with a call to wfScript(api) in a few places per co...werdna18:44, 30 September 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57119Re-work feed exposure system....werdna17:35, 30 September 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   18:18, 30 September 2009

You know actually this is still wrong -- we may have a different script suffix for isntance. Use wfScript('api')?

Status & tagging log