r57116 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57115‎ | r57116 | r57117 >
Date:16:45, 30 September 2009
Author:werdna
Status:deferred
Tags:
Comment:
Fixes for LiquidThreads NewMessages display.
* Change selector for LHS edge to select topmost threads, rather than threads a direct child of #bodyContent, which breaks in the case of Special:NewMessages.
* Fix display oddness caused by free-floating table width, force it to be 10em for the LHS, and the rest of the width for the RHS.
Modified paths:
  • /trunk/extensions/LiquidThreads/lqt.css (modified) (history)
  • /trunk/extensions/LiquidThreads/pages/NewUserMessagesView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/lqt.css
@@ -324,7 +324,7 @@
325325 margin-left: 2em;
326326 }
327327
328 -#bodyContent > .lqt_thread,
 328+.lqt-thread-topmost,
329329 .lqt-thread-replies {
330330 background-image: url(images/edge.png);
331331 background-repeat: repeat-y;
@@ -480,3 +480,11 @@
481481 .lqt-replies-finish {
482482 clear: both;
483483 }
 484+
 485+table.lqt-new-messages {
 486+ width: 100%;
 487+}
 488+
 489+.mw-lqt-newmessages-left {
 490+ width: 10em ;
 491+}
Index: trunk/extensions/LiquidThreads/pages/NewUserMessagesView.php
@@ -136,7 +136,7 @@
137137 $this->targets[$top->id()][] = $t->id();
138138 }
139139
140 - $this->output->addHTML( '<table><tbody>' );
 140+ $this->output->addHTML( '<table class="lqt-new-messages"><tbody>' );
141141
142142 foreach ( $this->tops as $t ) {
143143 // It turns out that with lqtviews composed of threads from various talkpages,

Status & tagging log