r57053 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57052‎ | r57053 | r57054 >
Date:13:26, 29 September 2009
Author:demon
Status:reverted
Tags:
Comment:
bug 20860 [[Special:Allmessages]] to have direct (edit) link
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialAllmessages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialAllmessages.php
@@ -299,7 +299,8 @@
300300
301301 $title = Title::makeTitle( NS_MEDIAWIKI, $value . $this->suffix );
302302 $talk = Title::makeTitle( NS_MEDIAWIKI_TALK, $value . $this->suffix );
303 -
 303+ $edit = $this->mSkin->link( $title, wfMsg( 'edit' ), array(), 'action=edit' );
 304+
304305 if( $this->mCurrentRow->am_customised ){
305306 $title = $this->mSkin->linkKnown( $title, $wgLang->lcfirst( $value ) );
306307 } else {
@@ -322,7 +323,7 @@
323324 array( 'broken' )
324325 );
325326 }
326 - return $title . ' (' . $talk . ')';
 327+ return $title . ' (' . $wgLang->pipeList( array( $edit, $talk ) ) . ')';
327328
328329 case 'am_default' :
329330 return Sanitizer::escapeHtmlAllowEntities( $value, ENT_QUOTES );
Index: trunk/phase3/RELEASE-NOTES
@@ -543,6 +543,7 @@
544544 now links to the file rather than the file description page
545545 * Password fields built with HTMLForm now still have the type="password" attribute
546546 if $wgHtml5=false.
 547+* (bug 20860) Entries on Special:Allmessages now have direct "edit" link
547548
548549 == API changes in 1.16 ==
549550

Follow-up revisions

RevisionCommit summaryAuthorDate
r57121Revert r57053 for now "bug 20860 [[Special:Allmessages]] to have direct (edit...brion17:50, 30 September 2009

Status & tagging log