r57050 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57049‎ | r57050 | r57051 >
Date:11:41, 29 September 2009
Author:nikerabbit
Status:ok
Tags:
Comment:
No empty exports. Spell out the key
Modified paths:
  • /trunk/extensions/Translate/FFS.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/FFS.php
@@ -445,6 +445,8 @@
446446 $messages[$key] = $value;
447447 }
448448
 449+ if ( !count($messages) ) return false;
 450+
449451 $messages = $this->unflatten( $messages );
450452
451453 # Some groups have messages under language code
@@ -593,7 +595,7 @@
594596 if ( isset(self::$pluralWords[$key]) ) {
595597 $plurals = true;
596598 } elseif( $plurals ) {
597 - throw new MWException( "Reserved plural keywords mixed with other keys" );
 599+ throw new MWException( "Reserved plural keywords mixed with other keys: $key" );
598600 }
599601 }
600602

Status & tagging log