r57018 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57017‎ | r57018 | r57019 >
Date:17:30, 28 September 2009
Author:siebrand
Status:ok
Tags:
Comment:
Fixes for IE per CR (http://www.mediawiki.org/wiki/Special:Code/MediaWiki/56032#c4178) and a few more in the same area.
Modified paths:
  • /trunk/phase3/js2/ajaxcategories.js (modified) (history)

Diff [purge]

Index: trunk/phase3/js2/ajaxcategories.js
@@ -27,8 +27,8 @@
2828 'cancel': function() {
2929 var req = ajaxCategories.request;
3030 if (req.abort)
31 - req.abort()
32 - },
 31+ req.abort();
 32+ }
3333 } );
3434
3535 $j('#mw-addcategory-input').suggestions();
@@ -131,7 +131,7 @@
132132 var dialogOptions = {
133133 'AutoOpen' : true,
134134 'buttons' : buttons,
135 - 'width' : 450,
 135+ 'width' : 450
136136 };
137137
138138 $j('#catlinks').prepend(dialog);
@@ -148,7 +148,7 @@
149149 'intoken':'edit',
150150 'titles':page,
151151 'rvprop':'content|timestamp',
152 - 'format':'json',
 152+ 'format':'json'
153153 };
154154
155155 $j.get(wgScriptPath+'/api.php', getTokenVars,
@@ -172,7 +172,7 @@
173173 'summary':summary,
174174 'token':token,
175175 'basetimestamp':timestamp,
176 - 'format':'json',
 176+ 'format':'json'
177177 };
178178
179179 $j.post( wgScriptPath+'/api.php', postEditVars, doneFn, 'json' );
@@ -266,11 +266,13 @@
267267 $j('#bodyContent').append(dialog);
268268
269269 var buttons = {};
270 - buttons[gM('ajax-error-dismiss')] = function(e) { dialog.dialog('close'); };
 270+ buttons[gM('ajax-error-dismiss')] = function(e) {
 271+ dialog.dialog('close');
 272+ };
271273 var dialogOptions = {
272274 'buttons' : buttons,
273275 'AutoOpen' : true,
274 - 'title' : gM('ajax-error-title'),
 276+ 'title' : gM('ajax-error-title')
275277 };
276278
277279 dialog.dialog(dialogOptions);
@@ -318,7 +320,7 @@
319321 } );
320322
321323 clElement.append(promptContainer);
322 - },
 324+ }
323325 };
324326
325327 js2AddOnloadHook( ajaxCategories.setupAJAXCategories );

Status & tagging log