r57012 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57011‎ | r57012 | r57013 >
Date:09:48, 28 September 2009
Author:catrope
Status:reverted
Tags:
Comment:
Fix for r56924: don't do any mouseover/mouseout effects while the spinner is being shown. Coding style cleanup will follow.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/common/ajaxwatch.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/ajaxwatch.js
@@ -159,12 +159,15 @@
160160 wgAjaxWatch.imgBasePath = el1.firstChild.firstChild.src
161161 .replace( /\/vector\/images\/watch_(off|on).gif/, "" );
162162 el1.firstChild.onmouseover = function( e ) {
163 - this.firstChild.src = wgAjaxWatch.imgBasePath
164 - + "/vector/images/watch_over.gif";
 163+ if ( !wgAjaxWatch.inprogress )
 164+ this.firstChild.src = wgAjaxWatch.imgBasePath
 165+ + "/vector/images/watch_over.gif";
165166 }
166167 el1.firstChild.onmouseout = function( e ) {
167 - this.firstChild.src = wgAjaxWatch.imgBasePath
168 - + "/vector/images/watch_" + ( wgAjaxWatch.watching ? "on.gif" : "off.gif");
 168+ if ( !wgAjaxWatch.inprogress )
 169+ this.firstChild.src = wgAjaxWatch.imgBasePath
 170+ + "/vector/images/watch_" + ( wgAjaxWatch.watching ?
 171+ "on.gif" : "off.gif" );
169172 }
170173 }
171174 } catch( e ) {
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1606,7 +1606,7 @@
16071607 * to ensure that client-side caches do not keep obsolete copies of global
16081608 * styles.
16091609 */
1610 -$wgStyleVersion = '241';
 1610+$wgStyleVersion = '242';
16111611
16121612
16131613 # Server-side caching:

Follow-up revisions

RevisionCommit summaryAuthorDate
r57125Revert r56924 (new watch icon and color changes for Vector) and followups r57...catrope17:58, 30 September 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56924Moving watch/unwatch action out of the drop downadam18:04, 25 September 2009

Status & tagging log