r56940 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r56939‎ | r56940 | r56941 >
Date:09:22, 26 September 2009
Author:catrope
Status:ok
Tags:
Comment:
API: (bug 20816) Editing a page with &watchlist=preferences (default) unwatches it if you're watching it but don't have watching preferences set. This is a regression from r53266
Modified paths:
  • /trunk/phase3/includes/api/ApiEditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiEditPage.php
——@@ -180,7 +180,7 @@
181181 break;
182182 case 'preferences':
183183 if ($titleObj->exists())
184 - $watch = $wgUser->getOption('watchdefault');
 184+ $watch = $wgUser->getOption('watchdefault') || $titleObj->userIsWatching();
185185 else
186186 $watch = $wgUser->getOption('watchcreations');
187187 break;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53266(bug 19090) Added watchlist parameter, deprecated watch and unwatch parameter...btongminh20:48, 14 July 2009

Status & tagging log