r56836 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56835‎ | r56836 | r56837 >
Date:20:54, 23 September 2009
Author:churchofemacs
Status:ok
Tags:
Comment:
Follow-up on r56832: fixing some minor issues avar brought to attention about patch to bug 20218
Modified paths:
  • /trunk/extensions/Cite/SpecialCite.i18n.php (modified) (history)
  • /trunk/extensions/Cite/SpecialCite.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Cite/SpecialCite.i18n.php
@@ -10,7 +10,7 @@
1111 $messages['en'] = array(
1212 'cite_article_desc' => 'Adds a [[Special:Cite|citation]] special page and toolbox link',
1313 'cite_article_link' => 'Cite this page',
14 - 'cite_article_link_title' => 'Information how to cite this page',
 14+ 'cite_article_link_title' => 'Information on how to cite this page',
1515 'cite' => 'Cite',
1616 'cite_page' => 'Page:',
1717 'cite_submit' => 'Cite',
Index: trunk/extensions/Cite/SpecialCite.php
@@ -9,7 +9,6 @@
1010 * @link http://www.mediawiki.org/wiki/Extension:Cite/Special:Cite.php Documentation
1111 *
1212 * @author Ævar Arnfjörð Bjarmason <avarab@gmail.com>
13 - * @author Ireas <ireas@rkrahl.de>
1413 * @copyright Copyright © 2005, Ævar Arnfjörð Bjarmason
1514 * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later
1615 */
@@ -17,7 +16,7 @@
1817 $wgExtensionCredits['specialpage'][] = array(
1918 'path' => __FILE__,
2019 'name' => 'Cite',
21 - 'author' => 'Ævar Arnfjörð Bjarmason, Ireas',
 20+ 'author' => 'Ævar Arnfjörð Bjarmason',
2221 'description' => 'adds a [[Special:Cite|citation]] special page & toolbox link', // kept for b/c
2322 'descriptionmsg' => 'cite_article_desc',
2423 'url' => 'http://www.mediawiki.org/wiki/Extension:Cite/Special:Cite.php'
@@ -47,7 +46,7 @@
4847 }
4948
5049 /**
51 - * call the function that adds the cite link in the toolbar
 50+ * add the cite link to the toolbar
5251 */
5352 function wfSpecialCiteToolbox( &$skin ) {
5453 if ( isset( $skin->data['nav_urls']['cite'] ) ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56832Patch by ireas for bug 20218: adding title attribute for toolbox link, making...churchofemacs19:55, 23 September 2009

Status & tagging log