r56797 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56796‎ | r56797 | r56798 >
Date:00:59, 23 September 2009
Author:aaron
Status:ok
Tags:
Comment:
merged r56490, r56496
Modified paths:
  • /branches/wmf-deployment/extensions/ReaderFeedback/specialpages/RatedPages_body.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/extensions/ReaderFeedback/specialpages/RatedPages_body.php
@@ -81,7 +81,7 @@
8282 }
8383 $ratinghist = SpecialPage::getTitleFor( 'RatingHistory' );
8484 $graph = $this->skin->makeKnownLinkObj( $ratinghist, wfMsg('ratedpages-graphs'),
85 - 'target='.$title->getPrefixedUrl() );
 85+ 'target='.$title->getPrefixedUrl().'&period=93' );
8686 return "<li>$link $stxt ($hist) ($graph)</li>";
8787 }
8888 }
@@ -120,9 +120,9 @@
121121 $conds['page_namespace'] = $this->namespace;
122122 // Has to be good/crappy enough
123123 switch( $this->tier ) {
124 - case 3: $conds[] = "rfp_ave_val > 3.5"; break;
 124+ case 3: $conds[] = "rfp_ave_val > 3"; break;
125125 case 1: $conds[] = "rfp_ave_val < 2"; break;
126 - default: $conds[] = "rfp_ave_val >= 2 AND rfp_ave_val <= 3.5"; break;
 126+ default: $conds[] = "rfp_ave_val >= 2 AND rfp_ave_val <= 3"; break;
127127 }
128128 // Reasonable samples only
129129 $conds[] = 'rfp_count >= '.ReaderFeedback::getFeedbackSize();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56490Make graph links default from 1->3 month rangeaaron02:58, 17 September 2009
r56496In Xml::encodeJsVar, keep backwards compatibility by encoding empty arrays as...werdna09:31, 17 September 2009

Status & tagging log