r56775 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56774‎ | r56775 | r56776 >
Date:17:23, 22 September 2009
Author:catrope
Status:ok
Tags:
Comment:
Fix up r56723: unbreak "replace all" mode
Modified paths:
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js
@@ -1238,6 +1238,9 @@
12391239 end = start + matches[i].length;
12401240 $textarea.setSelection( start, end );
12411241 $textarea.encapsulateSelection( '', replaceStr, '', false, true );
 1242+
 1243+ // $textarea.val() has changed
 1244+ text = fixOperaBrokenness( $textarea.val() );
12421245 }
12431246 if ( $j( '#edittoolbar-replace-all' ).is( ':checked' ) )
12441247 alert( gM( 'edittoolbar-tool-replace-success', i ) );
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.php
@@ -19,7 +19,7 @@
2020 /* Configuration */
2121
2222 // Bump the version number every time you change any of the .css/.js files
23 -$wgEditToolbarStyleVersion = 36;
 23+$wgEditToolbarStyleVersion = 37;
2424
2525 // Set this to true to simply override the stock toolbar for everyone
2626 $wgEditToolbarGlobalEnable = false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56723EditToolbar: (bug 20715) Search&Replace messes up in Opera...catrope18:05, 21 September 2009

Status & tagging log