r56725 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56724‎ | r56725 | r56726 >
Date:18:29, 21 September 2009
Author:brion
Status:ok
Tags:
Comment:
Merge trunk r56601: Don't drop default attrib values in non-HTML5 (bug 20713)
Modified paths:
  • /branches/wmf-deployment/includes/Html.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/includes/Html.php
@@ -195,6 +195,13 @@
196196 * @return array An array of attributes functionally identical to $attribs
197197 */
198198 private static function dropDefaults( $element, $attribs ) {
 199+ # Don't bother doing anything if we aren't outputting HTML5; it's too
 200+ # much of a pain to maintain two sets of defaults.
 201+ global $wgHtml5;
 202+ if ( !$wgHtml5 ) {
 203+ return $attribs;
 204+ }
 205+
199206 static $attribDefaults = array(
200207 'area' => array( 'shape' => 'rect' ),
201208 'button' => array(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56601Don't drop default attrib values in non-HTML5...simetrical14:19, 18 September 2009

Status & tagging log