r56703 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r56702‎ | r56703 | r56704 >
Date:14:18, 21 September 2009
Author:happy-melon
Status:reverted
Tags:
Comment:
Follow-up to r56683 - unnecessary abstraction
Modified paths:
  • /trunk/phase3/includes/ExternalUser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ExternalUser.php
——@@ -299,7 +299,7 @@
300300 array( 'eu_external_id' => $this->getId() )
301301 );
302302 return $row
303 - ? User::newFromId( $row->fetchObject()->eu_wiki_id )
 303+ ? User::newFromId( $row->eu_wiki_id )
304304 : null;
305305 }
306306

Follow-up revisions

RevisionCommit summaryAuthorDate
r56937Revert broken rewrite of login system; totally broken....brion00:49, 26 September 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56683New function for ExternalUser to get the local User corresponding to the exte...happy-melon18:53, 20 September 2009

Status & tagging log