r56698 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56697‎ | r56698 | r56699 >
Date:11:46, 21 September 2009
Author:catrope
Status:ok
Tags:
Comment:
EditToolbar: (bug 20581) Also pop up a dialog box when only one replacement was made in "replace all" mode
Modified paths:
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.i18n.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.js
@@ -1204,7 +1204,7 @@
12051205 $textarea.setSelection( start, end );
12061206 $textarea.encapsulateSelection( '', replaceStr, '', false, true );
12071207 }
1208 - if ( i > 1 )
 1208+ if ( $j( '#edittoolbar-replace-all' ).is( ':checked' ) )
12091209 alert( gM( 'edittoolbar-tool-replace-success', i ) );
12101210 $textarea.scrollToCaretPosition( start );
12111211 $textarea.setSelection( start, start + replaceStr.length );
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.i18n.php
@@ -109,7 +109,7 @@
110110 'edittoolbar-tool-replace-button' => 'Replace',
111111 'edittoolbar-tool-replace-close' => 'Cancel',
112112 'edittoolbar-tool-replace-nomatch' => 'Your search did not match anything.',
113 - 'edittoolbar-tool-replace-success' => '$1 replacements made.',
 113+ 'edittoolbar-tool-replace-success' => '$1 replacement(s) made.',
114114 /* Special characters Section */
115115 'edittoolbar-section-characters' => 'Special characters',
116116 'edittoolbar-characters-page-latin' => 'Latin',
Index: trunk/extensions/UsabilityInitiative/EditToolbar/EditToolbar.php
@@ -19,7 +19,7 @@
2020 /* Configuration */
2121
2222 // Bump the version number every time you change any of the .css/.js files
23 -$wgEditToolbarStyleVersion = 34;
 23+$wgEditToolbarStyleVersion = 35;
2424
2525 // Set this to true to simply override the stock toolbar for everyone
2626 $wgEditToolbarGlobalEnable = false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56194EditToolbar: (bug 20581, bug 20582, bug 20584) Make search&replace dialog sel...catrope18:10, 11 September 2009

Status & tagging log