r56662 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56661‎ | r56662 | r56663 >
Date:08:47, 20 September 2009
Author:demon
Status:ok
Tags:
Comment:
Installer spewing warnings due to disable_functions
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/config/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/config/Installer.php
@@ -2200,7 +2200,7 @@
22012201 function getShellLocale( $wikiLang ) {
22022202 # Give up now if we're in safe mode or open_basedir
22032203 # It's theoretically possible but tricky to work with
2204 - if ( wfIniGetBool( "safe_mode" ) || ini_get( 'open_basedir' ) ) {
 2204+ if ( wfIniGetBool( "safe_mode" ) || ini_get( 'open_basedir' ) || !function_exists('exec') ) {
22052205 return false;
22062206 }
22072207
Index: trunk/phase3/RELEASE-NOTES
@@ -510,6 +510,8 @@
511511 assume the user object is equal to the current-user object ($wgUser)
512512 * (bug 20517) Cancel link from edit page now returns to the old version when
513513 editing an old version
 514+* (bug 16902) Installer no longer shows warnings when exec() has been disabled
 515+ by disable_functions
514516
515517 == API changes in 1.16 ==
516518

Status & tagging log