r56539 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56538‎ | r56539 | r56540 >
Date:17:20, 17 September 2009
Author:werdna
Status:deferred
Tags:
Comment:
Fix typo in r56503
Modified paths:
  • /trunk/extensions/LiquidThreads/api/ApiFeedLQTThreads.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/api/ApiFeedLQTThreads.php
@@ -51,8 +51,9 @@
5252
5353 $db = wfGetDB( DB_SLAVE );
5454
55 - $feedTitle = $this->createFeedTitle( $params );
 55+ $feedTitle = self::createFeedTitle( $params );
5656 $feedClass = $wgFeedClasses[$params['feedformat']];
 57+ // TODO need a better URL :)
5758 $feedUrl = 'http://www.mediawiki.org/wiki/Extension:LiquidThreads';
5859 $feedItems = array();
5960
@@ -114,7 +115,7 @@
115116 return new FeedItem($titleStr, $completeText, $titleUrl, $timestamp, $user);
116117 }
117118
118 - private function createFeedTitle( $params ) {
 119+ public static function createFeedTitle( $params ) {
119120 wfLoadExtensionMessages( 'LiquidThreads' );
120121 $fromPlaces = array();
121122
@@ -141,10 +142,10 @@
142143 $msg = 'lqt-feed-title-all';
143144 } elseif ( in_array( 'replies', $types ) ) {
144145 $msg = 'lqt-feed-title-replies';
145 - } elseif ( in_array( 'newthrads', $types ) ) {
 146+ } elseif ( in_array( 'newthreads', $types ) ) {
146147 $msg = 'lqt-feed-title-new-threads';
147148 } else {
148 - throw new MWException( "Unable to determine appropriate display type" );
 149+ throw new MWException( "Unable to determine appropriate display type");
149150 }
150151
151152 if ( $fromCount ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56503Add feed support to LiquidThreads (resolves bug 20660, mostly)....werdna12:12, 17 September 2009

Status & tagging log