r56521 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56520‎ | r56521 | r56522 >
Date:15:11, 17 September 2009
Author:catrope
Status:ok
Tags:
Comment:
wmf-deployment: Merge r56492 (fix usercss/js logic)
Modified paths:
  • /branches/wmf-deployment/includes/Title.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/includes/Title.php
@@ -1290,12 +1290,12 @@
12911291 # XXX: Find a way to work around the php bug that prevents using $this->userCanEditCssSubpage()
12921292 # and $this->userCanEditJsSubpage() from working
12931293 # XXX: right 'editusercssjs' is deprecated, for backward compatibility only
1294 - if( $this->isCssSubpage() && ( !$user->isAllowed('editusercssjs') || !$user->isAllowed('editusercss') )
 1294+ if( $this->isCssSubpage() && !( $user->isAllowed('editusercssjs') || $user->isAllowed('editusercss') )
12951295 && $action != 'patrol'
12961296 && !preg_match('/^'.preg_quote($user->getName(), '/').'\//', $this->mTextform) )
12971297 {
12981298 $errors[] = array('customcssjsprotected');
1299 - } else if( $this->isJsSubpage() && ( !$user->isAllowed('editusercssjs') || !$user->isAllowed('edituserjs') )
 1299+ } else if( $this->isJsSubpage() && !( $user->isAllowed('editusercssjs') || $user->isAllowed('edituserjs') )
13001300 && $action != 'patrol'
13011301 && !preg_match('/^'.preg_quote($user->getName(), '/').'\//', $this->mTextform) )
13021302 {
Property changes on: branches/wmf-deployment/includes/Title.php
___________________________________________________________________
Name: svn:mergeinfo
13031303 + /branches/REL1_15/phase3/includes/Title.php:51646
/branches/wmf-deployment/includes/Title.php:53381
/trunk/phase3/includes/Title.php:56213,56215-56216,56218,56334-56336,56338,56340,56343,56345,56347,56350,56492

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56492Fix logic error from r54153. By negating each individual isAllowed check, the...mrzman04:27, 17 September 2009

Status & tagging log