r56512 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56511‎ | r56512 | r56513 >
Date:14:13, 17 September 2009
Author:raymond
Status:ok
Tags:
Comment:
Consistency tweak: Use pipe-separator for diff / hist like on RC and WL
BTW: RC and WL shows (diff | hist) but this page (hist | diff). Another consistency candidate?
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -418,7 +418,7 @@
419419
420420 function __construct( $target, $namespace = false, $year = false, $month = false, $tagFilter = false ) {
421421 parent::__construct();
422 - foreach( explode( ' ', 'uctop diff newarticle rollbacklink diff hist rev-delundel' ) as $msg ) {
 422+ foreach( explode( ' ', 'uctop diff newarticle rollbacklink diff hist rev-delundel pipe-separator' ) as $msg ) {
423423 $this->messages[$msg] = wfMsgExt( $msg, array( 'escape') );
424424 }
425425 $this->target = $target;
@@ -559,7 +559,7 @@
560560 }
561561 # Is there a visible previous revision?
562562 if( !$rev->isDeleted(Revision::DELETED_TEXT) ) {
563 - $difftext = '(' . $sk->linkKnown(
 563+ $difftext = $this->messages['pipe-separator'] . $sk->linkKnown(
564564 $page,
565565 $this->messages['diff'],
566566 array(),
@@ -569,14 +569,14 @@
570570 )
571571 ) . ')';
572572 } else {
573 - $difftext = '(' . $this->messages['diff'] . ')';
 573+ $difftext = $this->messages['pipe-separator'] . $this->messages['diff'] . ')';
574574 }
575575 $histlink = '('.$sk->linkKnown(
576576 $page,
577577 $this->messages['hist'],
578578 array(),
579579 array( 'action' => 'history' )
580 - ) . ')';
 580+ );
581581
582582 $comment = $wgContLang->getDirMark() . $sk->revComment( $rev, false, true );
583583 $date = $wgLang->timeanddate( wfTimestamp( TS_MW, $row->rev_timestamp ), true );

Status & tagging log