r56509 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56508‎ | r56509 | r56510 >
Date:13:01, 17 September 2009
Author:werdna
Status:ok
Tags:
Comment:
Merge r56508, regression spewing exceptions in CentralAuth in some circumstances
Modified paths:
  • /branches/wmf-deployment/extensions/CentralAuth/CentralAuthHooks.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/extensions/CentralAuth/CentralAuthHooks.php
@@ -187,12 +187,12 @@
188188 // Sanity check to avoid session ID collisions, as reported on bug 19158
189189 if ( !isset($_COOKIE["{$prefix}User"]) ) {
190190 wfDebug( __METHOD__.": no User cookie, so unable to check for session mismatch\n" );
191 - return;
 191+ return true;
192192 } elseif ( $_COOKIE["{$prefix}User"] != $userName ) {
193193 wfDebug( __METHOD__.": Session ID/User mismatch. Possible session collision. ".
194194 "Expected: $userName; actual: ".
195195 $_COOKIE["{$prefix}User"]."\n" );
196 - return;
 196+ return true;
197197 }
198198
199199 // Clean up username
Property changes on: branches/wmf-deployment/extensions/CentralAuth/CentralAuthHooks.php
___________________________________________________________________
Name: svn:mergeinfo
200200 + /branches/REL1_15/phase3/extensions/CentralAuth/CentralAuthHooks.php:51646
/trunk/extensions/CentralAuth/CentralAuthHooks.php:56207,56209,56296,56333,56355,56508
/trunk/phase3/extensions/CentralAuth/CentralAuthHooks.php:56213,56215-56216,56218,56325,56334-56336,56338,56340,56343,56345,56347,56350

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56508Fix failure to return a value, regression spewing errorswerdna13:00, 17 September 2009

Status & tagging log