r56464 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56463‎ | r56464 | r56465 >
Date:00:12, 17 September 2009
Author:aaron
Status:ok
Tags:
Comment:
Bump releasenote range limit and actually give a notice when out of it
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeReleaseNotes.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -95,6 +95,7 @@
9696 'code-release-legend' => 'Generate release notes',
9797 'code-release-startrev' => 'Start rev:',
9898 'code-release-endrev' => 'Last rev:',
 99+ 'code-release-badrange' => 'Range is too large!',
99100
100101 'codereview-subtitle' => 'For $1',
101102
Index: trunk/extensions/CodeReview/ui/CodeReleaseNotes.php
@@ -27,8 +27,11 @@
2828 $this->showForm();
2929 # Sanity/performance check...
3030 $lastRev = $this->mRepo->getLastStoredRev();
31 - if ( $this->mStartRev < ( $lastRev - 3000 ) )
32 - $this->mStartRev = NULL;
 31+ if ( $this->mStartRev < ( $lastRev - 5000 ) ) {
 32+ global $wgOut;
 33+ $wgOut->addHtml( wfMsgHtml('code-release-badrange') );
 34+ return;
 35+ }
3336 # Show notes if we have at least a starting revision
3437 if ( $this->mStartRev ) {
3538 $this->showReleaseNotes();

Status & tagging log