r56419 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56418‎ | r56419 | r56420 >
Date:17:06, 16 September 2009
Author:brion
Status:deferred
Tags:
Comment:
Merge r56356 from trunk -- workaround to let us deal with the index setup funk for changetags
Modified paths:
  • /branches/wmf-deployment-work/includes/ChangeTags.php (modified) (history)
  • /branches/wmf-deployment-work/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment-work/includes/ChangeTags.php
@@ -125,7 +125,9 @@
126126 // Add an INNER JOIN on change_tag
127127
128128 // FORCE INDEX -- change_tags will almost ALWAYS be the correct query plan.
129 - $options['USE INDEX'] = array( 'change_tag' => 'change_tag_tag_id' );
 129+ global $wgOldChangeTagsIndex;
 130+ $index = $wgOldChangeTagsIndex ? 'ct_tag' : 'change_tag_tag_id';
 131+ $options['USE INDEX'] = array( 'change_tag' => $index );
130132 unset( $options['FORCE INDEX'] );
131133 $tables[] = 'change_tag';
132134 $join_conds['change_tag'] = array( 'INNER JOIN', "ct_$join_cond=$join_cond" );
Index: branches/wmf-deployment-work/includes/DefaultSettings.php
@@ -4235,3 +4235,8 @@
42364236
42374237 // to disable image delete/restore temporarily
42384238 $wgUploadMaintenance = false;
 4239+
 4240+/**
 4241+ * Use old names for change_tags indices.
 4242+ */
 4243+$wgOldChangeTagsIndex = false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56356Make Change Tags index name configurable with a new config variable $wgOldCha...werdna10:28, 15 September 2009

Status & tagging log