r56379 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56378‎ | r56379 | r56380 >
Date:18:09, 15 September 2009
Author:werdna
Status:deferred
Tags:
Comment:
Use anchors instead of direct links for permalinks in notifications
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/NewMessagesController.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/NewMessagesController.php
@@ -237,7 +237,9 @@
238238 );
239239
240240 // Set up one-time data.
241 - $permalink = LqtView::permalinkUrl( $t );
 241+ $link_title = clone $t->article()->getTitle();
 242+ $link_title->setFragment( '#'.$t->getAnchorName() );
 243+ $permalink = $link_title->getFullURL();
242244 $talkPage = $t->article()->getTitle()->getPrefixedText();
243245 $from = new MailAddress( $wgPasswordSender, 'WikiAdmin' );
244246 $threadSubject = $t->subject();

Status & tagging log