r56357 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56356‎ | r56357 | r56358 >
Date:12:41, 15 September 2009
Author:siebrand
Status:ok
Tags:
Comment:
* fix oversight in r56324 in showMissingArticle() (string -> array)
* break lists of parameters for other uses of LogEventsList::showLogExtract()
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -1213,8 +1213,16 @@
12141214 }
12151215 wfRunHooks( 'ShowMissingArticle', array( $this ) );
12161216 # Show delete and move logs
1217 - LogEventsList::showLogExtract( $wgOut, array( 'delete', 'move' ),
1218 - $this->mTitle->getPrefixedText(), '', 10, array( "log_action != 'revision'" ), false, 'moveddeleted-notice');
 1217+ LogEventsList::showLogExtract(
 1218+ $wgOut,
 1219+ array( 'delete', 'move' ),
 1220+ $this->mTitle->getPrefixedText(),
 1221+ '',
 1222+ 10,
 1223+ array( "log_action != 'revision'" ),
 1224+ false,
 1225+ array( 'moveddeleted-notice' )
 1226+ );
12191227
12201228 # Show error message
12211229 $oldid = $this->getOldID();
@@ -2548,7 +2556,11 @@
25492557 if( $latest === false ) {
25502558 $wgOut->showFatalError( wfMsgExt( 'cannotdelete', array( 'parse' ) ) );
25512559 $wgOut->addHTML( Xml::element( 'h2', null, LogPage::logName( 'delete' ) ) );
2552 - LogEventsList::showLogExtract( $wgOut, 'delete', $this->mTitle->getPrefixedText() );
 2560+ LogEventsList::showLogExtract(
 2561+ $wgOut,
 2562+ 'delete',
 2563+ $this->mTitle->getPrefixedText()
 2564+ );
25532565 return;
25542566 }
25552567
@@ -2756,7 +2768,11 @@
27572769
27582770 $wgOut->addHTML( $form );
27592771 $wgOut->addHTML( Xml::element( 'h2', null, LogPage::logName( 'delete' ) ) );
2760 - LogEventsList::showLogExtract( $wgOut, 'delete', $this->mTitle->getPrefixedText() );
 2772+ LogEventsList::showLogExtract(
 2773+ $wgOut,
 2774+ 'delete',
 2775+ $this->mTitle->getPrefixedText()
 2776+ );
27612777 }
27622778
27632779 /**
@@ -2784,7 +2800,11 @@
27852801 if( $error == '' ) {
27862802 $wgOut->showFatalError( wfMsgExt( 'cannotdelete', array( 'parse' ) ) );
27872803 $wgOut->addHTML( Xml::element( 'h2', null, LogPage::logName( 'delete' ) ) );
2788 - LogEventsList::showLogExtract( $wgOut, 'delete', $this->mTitle->getPrefixedText() );
 2804+ LogEventsList::showLogExtract(
 2805+ $wgOut,
 2806+ 'delete',
 2807+ $this->mTitle->getPrefixedText()
 2808+ );
27892809 } else {
27902810 $wgOut->showFatalError( $error );
27912811 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56324Support GENDER in 'renameuser-renamed-notice', changing LogEventsList::showLo...siebrand18:58, 14 September 2009

Status & tagging log